Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RE-618: Automate C7->A8 happy path regression test on PR creation #494

Merged
merged 1 commit into from
Aug 22, 2024
Merged

RE-618: Automate C7->A8 happy path regression test on PR creation #494

merged 1 commit into from
Aug 22, 2024
+562 −0

Conversation

davelcpanelnet
Copy link
Contributor

  • Uses Github Actions and Terraform to create a centos-7 instance running the latest 11.110.0.* build.
  • Checks out the source PR branch.
  • Copies Elevate from source PR branch into /scripts/elevate-cpanel.
  • Updates cPanel License.
  • Runs elevate-cpanel.
  • Tracks each reboot and cycles through them
  • Upon completion of elevate-cpanel prove is run against t/integration/* where only complete.t currently resides and can be heavily expanded with additional tests.
  • Upon successful pipeline - the OpenStack instance is destroyed.
  • Upon failed pipeline - the OpenStack instance is kept alive for investigation.

@davelcpanelnet davelcpanelnet added the enhancement New feature or request label Aug 14, 2024
@davelcpanelnet
Copy link
Contributor Author

Pipeline that ran in my fork prior to PR: https://github.com/davelcpanelnet/elevate/actions/runs/10380441467

cPholloway
cPholloway requested changes Aug 14, 2024
View reviewed changes
.github/workflows/openstack.yml Outdated Show resolved Hide resolved
.github/workflows/openstack.yml Show resolved Hide resolved
.github/workflows/openstack/terraform/run_elevate.sh Outdated Show resolved Hide resolved
.github/workflows/openstack/terraform/run_elevate.sh Outdated Show resolved Hide resolved
.github/workflows/website.yml Outdated Show resolved Hide resolved
cPholloway
cPholloway approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@cPholloway cPholloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go ahead and approve this without the preconfig change as we can always add that in later and this is definitely a good framework for what we want to do

@cPholloway
Copy link
Contributor

@toddr - AC has been met now, and I verified that #497 passes with this change.

I think this is ready to merge now.

@toddr toddr merged commit cb95554 into cpanel:main Aug 22, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPholloway cPholloway cPholloway approved these changes

@toddr toddr Awaiting requested review from toddr

@troglodyne troglodyne Awaiting requested review from troglodyne

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davelcpanelnet @cPholloway @toddr @troglodyne